Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
$macc
is needlessly complex: theCONFIG
parameter uses a convoluted encoding, and it has a redundantB
port for single-bit summands.With
$macc_v2
the goal is to make it simpler, so much so that it's not unreasonable to write techmap rules matching on this cell in plain Verilog (as opposed to just deferring tomaccmap
).Explain how this is achieved.
Changes done in v2:
$mem_v2
, which similarly encodes a dynamic number of read/write ports)Based off #4817, which can go in first to make this one easier to review.
TODO:
$macc_v2
techmap.v